Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated root to tip of branch master #8830

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Updated root to tip of branch master #8830

merged 2 commits into from
Nov 22, 2023

Conversation

iarspider
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_14_0_X/rootmaster.

@aandvalenzuela, @smuzaffar, @cmsbuild, @iarspider can you please review it and eventually sign? Thanks.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #8830 was updated.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d6128/35965/summary.html
COMMIT: 69418c5
CMSSW: CMSSW_14_0_ROOT6_X_2023-11-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8830/35965/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test RecoPPSLocalNewT2 had ERRORS

Comparison Summary

Summary:

  • You potentially added 348 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 26591 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3363868
  • DQMHistoTests: Total failures: 124734
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3239111
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.46499999999999997 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.244 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.229 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.480 KiB SiStrip/MechanicalView
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 10 / 48 workflows

@iarspider
Copy link
Contributor Author

Unit test failure is known and not related to ROOT update

@iarspider
Copy link
Contributor Author

please test with cms-sw/cmssw#43340

@smuzaffar
Copy link
Contributor

good to go in root6 master IBs

@smuzaffar smuzaffar merged commit e64f736 into cms-sw:IB/CMSSW_14_0_X/rootmaster Nov 22, 2023
9 of 11 checks passed
@iarspider iarspider deleted the root-update-master-20231120 branch November 22, 2023 12:55
@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d6128/35990/summary.html
COMMIT: 69418c5
CMSSW: CMSSW_14_0_X_2023-11-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8830/35990/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d6128/35990/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d6128/35990/git-merge-result

Build

I found compilation error when building:

#10 0x0000000000406fce in _start ()
===========================================================


/bin/sh: line 1: 3593482 Segmentation fault      (core dumped) edmWriteConfigs -p /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-21-2300/tmp/el8_amd64_gcc12/src/Calibration/LumiAlCaRecoProducers/plugins/AlcaPCCEventProducer/libAlcaPCCEventProducer.so
gmake: *** [lib/el8_amd64_gcc12/AlcaPCCEventProducer.edmplugin] Error 1
Entering library rule at src/Calibration/LumiAlCaRecoProducers/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-21-2300/src/Calibration/LumiAlCaRecoProducers/plugins/AlcaPCCIntegrator.cc
>> Building edm plugin tmp/el8_amd64_gcc12/src/Calibration/LumiAlCaRecoProducers/plugins/AlcaPCCIntegrator/libAlcaPCCIntegrator.so
Leaving library rule at src/Calibration/LumiAlCaRecoProducers/plugins
@@@@ Running edmWriteConfigs for AlcaPCCIntegrator

@cmsbuild cmsbuild mentioned this pull request Feb 2, 2024
Merged
@cmsbuild cmsbuild mentioned this pull request Feb 19, 2024
Closed
@cmsbuild cmsbuild mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures requires-external tests-rejected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iarspider @cmsbuild @smuzaffar